Skip to content

consensus: mark envelopes non-exhaustive #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prestwich merged 1 commit into from
Apr 5, 2024
Merged

consensus: mark envelopes non-exhaustive #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/consensus/src/receipt/envelope.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use alloy_rlp::{length_of_length, BufMut, Decodable, Encodable};
#[derive(Debug, Clone, PartialEq, Eq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
#[cfg_attr(feature = "serde", serde(tag = "type"))]
#[non_exhaustive]
pub enum ReceiptEnvelope<T = Log> {
/// Receipt envelope with no type flag.
#[cfg_attr(feature = "serde", serde(rename = "0x0", alias = "0x00"))]
Expand Down
1 change: 1 addition & 0 deletions crates/consensus/src/transaction/envelope.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ impl TryFrom<u8> for TxType {
#[derive(Debug, Clone, PartialEq, Eq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
#[cfg_attr(feature = "serde", serde(tag = "type"))]
#[non_exhaustive]
pub enum TxEnvelope {
/// An untagged [`TxLegacy`].
#[cfg_attr(feature = "serde", serde(rename = "0x0", alias = "0x00"))]
Expand Down
1 change: 1 addition & 0 deletions crates/rpc-types/src/eth/transaction/receipt.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ impl TransactionReceipt {
| ReceiptEnvelope::Eip2930(receipt)
| ReceiptEnvelope::Eip4844(receipt)
| ReceiptEnvelope::Legacy(receipt) => receipt.receipt.status,
_ => false,
Copy link
Copy Markdown
Member

@prestwich prestwich Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Followup work:

  • trait Receipt in alloy-network
  • Receipt bound on type Recept in trait Network
  • fn status in trait Receipt
  • impl Receipt for ReceiptEnvelope and related types
  • change this function to a delegate to Receipt

}
}

Expand Down