consensus: mark envelopes non-exhaustive#456
Merged
prestwich merged 1 commit intoalloy-rs:mainfrom Apr 5, 2024
Merged
Conversation
yash-atreya
requested review from
DaniPopes,
Evalir,
gakonst,
mattsse,
onbjerg and
prestwich
as code owners
Evalir
approved these changes
Apr 4, 2024
Contributor
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
agreed that these are needed—shouldn't be much of an issue downstream other than having to add the wildcard when pattern matching
prestwich
reviewed
Apr 5, 2024
| | ReceiptEnvelope::Eip2930(receipt) | ||
| | ReceiptEnvelope::Eip4844(receipt) | ||
| | ReceiptEnvelope::Legacy(receipt) => receipt.receipt.status, | ||
| _ => false, |
Member
There was a problem hiding this comment.
Followup work:
trait Receiptin alloy-network- Receipt bound on
type Receptintrait Network fn statusintrait Receiptimpl Receipt for ReceiptEnvelopeand related types- change this function to a delegate to
Receipt
prestwich
approved these changes
Apr 5, 2024
Member
|
rebased to resolve conflict with #461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ref #451
Solution
PR Checklist