StructureFromMotion: Add new inputs parameters #1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two new input parameters, `nbFirstUnstableCameras` which sets the number of cameras for which a bundle adjustment is performed every time a camera is added, and `maxImagesPerGroup` which sets the maximum number of cameras that can be added before the bundle adjustment has to be performed again. By default, the bundle adjustment will be performed every time one of the first 30 cameras is added, as computations are not too expensive while there are few cameras. Past that number, the bundle adjustment will only be performed when up to 30 cameras have been added. The node's version is updated accordingly.
cbentejac
changed the title
fabiencastan
added
the
feature
fabiencastan
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add two new input parameters to the
StructureFromMotionnode:nbFirstUnstableCameraswhich sets the number of cameras for which a bundle adjustment is performed every time a camera is added;maxImagesPerGroupwhich sets the maximum number of cameras that can be added before the bundle adjustment has to be performed again.By default, the bundle adjustment will be performed every time one of the first 30 cameras is added, as computations are not too expensive while there are few cameras. Past that number, the bundle adjustment will only be performed when up to 30 cameras have been added.
The node's version and the templates using the
StructureFromMotionnode are updated accordingly.Related AliceVision pull request: alicevision/AliceVision#1413