Image Gallery: Add a menu to set the StructureFromMotion initial pair from the gallery #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"initialPairA" and "initialPairB" can either be the filename of the image (without the path), the whole path of the image, or its view ID.
Add a "SfM: Define Initial Pair" sub-menu in the Image Gallery menu that is only enabled if the currently active group contains a StructureFromMotion node. Clicking "A" or "B" will automatically set the selected image's view ID as a part of the initial pair.
cbentejac
changed the title
fabiencastan
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a "SfM: Define Initial Pair" menu in the Image Gallery, which allows the user to set the "Initial Pair A" and "Initial Pair B" parameters from the
StructureFromMotionnode with the currently selected image's view ID.The menu is only enabled if there is a
StructureFromMotionnode in the active group.The description of the
initialPairAandinitialPairBparameters in theStructureFromMotionnode is also updated with the list of accepted values for these parameters (filename, filepath, or view ID).