Merge pull request #1936 from alicevision/dev/sfmSetPair

Image Gallery: Add a menu to set the StructureFromMotion initial pair from the gallery
alicevision · Mar 18, 2023 · 9d269ba · 9d269ba
2 parents 736d069 + 790ede0
commit 9d269ba
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/meshroom/nodes/aliceVision/StructureFromMotion.py b/meshroom/nodes/aliceVision/StructureFromMotion.py
@@ -318,14 +318,14 @@ class StructureFromMotion(desc.AVCommandLineNode):
         desc.File(
             name='initialPairA',
             label='Initial Pair A',
-            description='Filename of the first image (without path).',
+            description='View ID or filename of the first image (either with or without the full path).',
             value='',
             uid=[0],
         ),
         desc.File(
             name='initialPairB',
             label='Initial Pair B',
-            description='Filename of the second image (without path).',
+            description='View ID or filename of the second image (either with or without the full path).',
             value='',
             uid=[0],
         ),

diff --git a/meshroom/ui/qml/ImageGallery/ImageDelegate.qml b/meshroom/ui/qml/ImageGallery/ImageDelegate.qml
@@ -84,6 +84,22 @@ Item {
                 enabled: !root.readOnly && _viewpoint.viewId != -1 && _reconstruction && activeNode
                 onClicked: activeNode.attribute("transformation").value = _viewpoint.viewId.toString()
             }
+            Menu {
+                id: sfmSetPairMenu
+                title: "SfM: Define Initial Pair"
+                property var activeNode: _reconstruction ? _reconstruction.activeNodes.get("StructureFromMotion").node : null
+                enabled: !root.readOnly && _viewpoint.viewId != -1 && _reconstruction && activeNode
+
+                MenuItem {
+                    text: "A"
+                    onClicked: sfmSetPairMenu.activeNode.attribute("initialPairA").value = _viewpoint.viewId.toString()
+                }
+
+                MenuItem {
+                    text: "B"
+                    onClicked: sfmSetPairMenu.activeNode.attribute("initialPairB").value = _viewpoint.viewId.toString()
+                }
+            }
         }
 
         ColumnLayout {