Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAW advanced processing #1918

Merged
merged 8 commits into from
Mar 9, 2023
Merged

RAW advanced processing #1918

merged 8 commits into from
Mar 9, 2023

Conversation

demoulinv
Copy link
Contributor

@demoulinv demoulinv commented Mar 3, 2023

Description

Expose some parameters dedicated to raw decoding and DCP color profile application.
Add option in panoramaPostProcessing node to select the output color space.
Remove dcpMetadata choice in cameraInit.

Based on alicevision/AliceVision#1368

@fabiencastan fabiencastan changed the title Dev/raw advanced processing RAW advanced processing Mar 5, 2023
@fabiencastan fabiencastan added this to the Meshroom 2023.1.0 milestone Mar 5, 2023
Disable workingColorSpace option when applyDCPMetadata is activated.
Add output color space option
Add no_conversion option value in HDR fusion for working color space.
Remove DCPMetadata option in the rawColorInterpretation choiceParam.
desc.ChoiceParam(
name='highlightMode',
label='Highlight mode',
description='LibRaw highlight mode\n',
Copy link
Member

@fabiencastan fabiencastan Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the description for each code or an enum.
No need for "\n" if there is only one line.

@fabiencastan fabiencastan merged commit 393ab5e into develop Mar 9, 2023
@fabiencastan fabiencastan deleted the dev/rawAdvancedProcessing branch March 9, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants