RAW advanced processing #1368
Merged
RAW advanced processing #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update rawInterpretation "None" by adding parameters Remove White Balancing if done by libRaw in DCP ColorMatrixOnly mode
Code cleaning For both libraw raw interpretation (w/wo white balancing) consider camera color matrix when reading dng files.
Align handling of raw color interpretation case of dcpMetadata, whether the imageProcessing node uses a view from an sfmData or an input image file. Add AliceVision:ColorSpace in view metadata. Force workingColorSpace to 'no_conversion' if applyDCPMetadata option is enabled.
Add output color space option. Code factorization for dcp loading from map of metadata
…in a non raw image format.
demoulinv
force-pushed
the
dev/rawAdvancedProcessing
branch
from
36c1e93
to
c41a19d
Compare
Change from AHD to DHT as demosaicing algo Change from LibRawNoWhiteBalancing to DcpLinearProcessing as default raw color interpretation in imageProcessing.
fabiencastan
reviewed
Mar 7, 2023
fabiencastan
reviewed
Mar 7, 2023
fabiencastan
reviewed
Mar 7, 2023
fabiencastan
reviewed
Mar 7, 2023
fabiencastan
reviewed
Mar 7, 2023
fabiencastan
reviewed
Mar 7, 2023
Adjust output color to 'Linear' space when working color space is 'sRGB'. Set back AHD as default demosaicing algo.
fabiencastan
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Expose some parameters dedicated to raw decoding and DCP color profile application.
Features list
libraw parameters: highlight Mode, demosaicking algo
White Balancing: Before (libraw) or after (AV) demosaicking
DCP parameter: apply Color Matrix only
Enable reading of images containing raw data in a non raw format (exr)
Add option to select the output color space of a RS panorama in panorama post processing node.
Implementation remarks