Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Viewer] Load and unload the SfMStats components explicitly every time they are shown and hidden #1912

Merged
merged 3 commits into from
Mar 3, 2023
Merged

[Viewer] Load and unload the SfMStats components explicitly every time they are shown and hidden #1912

merged 3 commits into from
Mar 3, 2023

Commits on Feb 27, 2023

  1. [Viewer] Viewer2D: Load and unload SfmStats components explicitly 

    The SfmStatsView and SfmGlobalStats components used to be loaded once
and for all with "Component.onCompleted". With the upgrade to Qt 5.14,
it is needed to load and explicitly unload the component (by resetting its
source) for the statistics to always be correctly displayed. Otherwise,
they can be loaded and viewed only once per session; after being shown for
the first time, they are set to null and never reloaded.

This commit uses the same type of loading/unloading as all the other
components in the 2D Viewer.
    @cbentejac
    cbentejac committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    15f963a View commit details
    Browse the repository at this point in the history

  2. [Viewer] Viewer2D: Remove trailing whitespaces

    @cbentejac
    cbentejac committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    f4418f4 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. [Viewer] Viewer2D: Add name of the active SfM node in the SfMStats to… 

    …oltips
    @cbentejac
    cbentejac committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    01be6d8 View commit details
    Browse the repository at this point in the history