[Viewer] Load and unload the SfMStats components explicitly every time they are shown and hidden #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SfmStatsView and SfmGlobalStats components used to be loaded once and for all with "Component.onCompleted". With the upgrade to Qt 5.14, it is needed to load and explicitly unload the component (by resetting its source) for the statistics to always be correctly displayed. Otherwise, they can be loaded and viewed only once per session; after being shown for the first time, they are set to null and never reloaded. This commit uses the same type of loading/unloading as all the other components in the 2D Viewer.
fabiencastan
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue that occurs when displaying the "StructureFromMotion Statistics" and "StructureFromMotion Global Statistics" components more than once per session. The components would be correctly loaded upon their first display, but disabling them and redisplaying them would lead to empty graphs, as the SfMData would not be correctly reloaded.
The SfMData is now provided to the components every time they are to be displayed (instead of providing it only once the first time they were to be displayed, and then never again), and the components' source is explicitly unloaded when they are hidden again. The behaviour of the statistics components is now similar to the other components' (such as the FeatureViewer, for example).
The image on the left below shows the statistics graphs that were displayed upon the SfMStats components' second display, while the image on the right shows how they always are with this PR (and not only for the first display).
Features list