New ColorChecker Detection and Correction #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiencastan
changed the title
meshroom/ui/reconstruction.py
Outdated
Comment on lines
493
to
495
| elif p.lower() == "colorcheckerdetection": | ||
| # test color checker detection pipeline | ||
| self.setGraph(multiview.colorCheckerDetection()) |
There was a problem hiding this comment.
Suggested change
| elif p.lower() == "colorcheckerdetection": | |
| # test color checker detection pipeline | |
| self.setGraph(multiview.colorCheckerDetection()) |
The code used here does not exist anymore.
| property real zoom: 1.0 | ||
|
|
||
| // required for perspective transform | ||
| readonly property real ccheckerSizeX: 1675.0 |
There was a problem hiding this comment.
Where does this value come from?
…mData If we have used a single image in input of the ColorCheckerDetection, still allow to display it. In this particular case, there is no notion of viewId.
_setSelectedViewpoint does not emit a signal, so it should be a private function.
fcastan
force-pushed
the
dev/colorChecker
branch
from
a1afa23
to
a17fdf3
Compare
fabiencastan
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Color checker detection and Color checker correction nodes (beta)
Features list
No support for Fisheye images.
Based on alicevision/AliceVision#973