[software] New ColorChecker Detection and Correction #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return pt; | ||
| } | ||
| }; | ||
|
|
||
|
|
||
| void detectColorChecker( | ||
| std::vector<CCheckerData> &detectedCCheckers, | ||
| std::vector<MacbethCCheckerQuad> &detectedCCheckers, | ||
| ImageOptions& imgOpt, | ||
| CCheckerDetectionSettings &settings) |
There was a problem hiding this comment.
const CCheckerDetectionSettings &settings
| // Load image | ||
| image::Image<image::RGBAfColor> img; | ||
| image::readImage(imgSrcPath, img, imgOpt.readOptions); | ||
| cv::Mat imgBGR = image::imageRGBAToCvMatBGR(img, CV_8UC3); |
There was a problem hiding this comment.
To convert to 8 bits the image needs to be in sRGB in all case (so it cannot rely on imgOpt.readOptions input parameter).
To read the color values in floating point to compute the color transformation, the image needs to be in the original file format colorspace or in linear (just need to use the same convention where we apply it).
fabiencastan
changed the title
|
|
||
| cv::Mat img; | ||
| cvtColor(imageBGR, img, cv::COLOR_BGR2RGB); | ||
| img.convertTo(img, CV_64F); |
There was a problem hiding this comment.
Is there a reason to use CV_64F instead of CV_32F?
add basic printing in log file
[software] colorChecker: rename functions [software] colorChecker: fix [software] colorChecker: turbo fix
To fix: read image as float value
Co-authored-by: Fabien Castan <[email protected]>
fcastan
force-pushed
the
dev/colorChecker
branch
from
9c2e672
to
665e02f
Compare
Add MCC module to opencv which requires >= opencv-4.5.0 Update opencv to 4.5.2
ceres use git url and not an archive
fcastan
force-pushed
the
dev/colorChecker
branch
from
7a001c5
to
af7be7f
Compare
fabiencastan
approved these changes
Apr 26, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Color checker detection and Color checker corection nodes (beta)
Features list