Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuseCut] added a parameter to filter points based on number of observations #885

Merged
merged 4 commits into from
Dec 1, 2020
Merged

[fuseCut] added a parameter to filter points based on number of observations #885

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
928d69e
new param minVis
raphael2692 Sep 10, 2020
07b6f80
Update DelaunayGraphCut.cpp
raphael2692 Sep 10, 2020
2ce4a31
new parameter minVis
raphael2692 Sep 10, 2020
3eca2c4
post-review update
raphael2692 Sep 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/aliceVision/fuseCut/DelaunayGraphCut.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,6 +1078,13 @@ void DelaunayGraphCut::fuseFromDepthMaps(const StaticVector<int>& cams, const Po
pixSizePrepare[vIndex] = -1;
continue;
}
// Filter points based on their number of observations
if(visCams.size() < params.minVis)
{
ALICEVISION_LOG_DEBUG("minVis value:" << params.minVis);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this log, add a counter, and log at the end the number of points filtered based on the number of observations.

pixSizePrepare[vIndex] = -1;
continue;
}

const double angleScore = 1.0 + params.angleFactor / maxAngle;
// Combine angleScore with simScore
Expand Down
2 changes: 2 additions & 0 deletions src/aliceVision/fuseCut/DelaunayGraphCut.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ struct FuseParams
/// The step used to load depth values from depth maps is computed from maxInputPts. Here we define the minimal value for this step,
/// so on small datasets we will not spend too much time at the beginning loading all depth values.
int minStep = 2;
/// After fusion, filter points based on their number of observations
int minVis = 2;

float simFactor = 15.0f;
float angleFactor = 15.0f;
Expand Down
2 changes: 2 additions & 0 deletions src/software/pipeline/main_meshing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,8 @@ int aliceVision_main(int argc, char* argv[])
"simFactor")
("angleFactor", po::value<float>(&fuseParams.angleFactor)->default_value(fuseParams.angleFactor),
"angleFactor")
("minVis", po::value<int>(&fuseParams.minVis)->default_value(fuseParams.minVis),
"Filter points based on their number of observations")
("partitioning", po::value<EPartitioningMode>(&partitioningMode)->default_value(partitioningMode),
"Partitioning: 'singleBlock' or 'auto'.")
("repartition", po::value<ERepartitionMode>(&repartitionMode)->default_value(repartitionMode),
Expand Down