[fuseCut] added a parameter to filter points based on number of observations #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a condition in DelaunayGraphCut::fuseFromDepthMaps to filter out points based on their number of observations (passed via the minVis parameter).
| // Filter points based on their number of observations | ||
| if(visCams.size() < params.minVis) | ||
| { | ||
| ALICEVISION_LOG_DEBUG("minVis value:" << params.minVis); |
There was a problem hiding this comment.
Remove this log, add a counter, and log at the end the number of points filtered based on the number of observations.
add counter for points filtered out (not enough observation) add info log for total count add info log for parameter minVis in log header
fabiencastan
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new parameter (minVis) in the graph cut step in order to filter out points with observation < minVis.
Features list
New parameter for the meshing node of the reconstruction pipe.
Implementation remarks
I think the implementation is trivial however I am not sure the new parameter should have been referenced elsewhere in the code (I know it should be added to meshroom API).