forked from iftechfoundation/ifdb
-
Notifications
You must be signed in to change notification settings - Fork 0
Filter games merged #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-blue
merged 33 commits into
alice-blue:filter-games-version-3
from
dfabulich:filter-games-merged
Jan 22, 2025
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2d40c71
newitems.php: use doSearch for getting new games
alice-blue eb97d6b
searchutil.php: select createdate for game listings so we can use it …
alice-blue c5fcdb9
`#ratings:` search should use `numRatingsInAvg` not `numRatingsTotal`
dfabulich c050f71
Search results call it `devsys` instead of `system`
dfabulich a7d6d0e
newitems.php: remove unnecessary 0 in limit clause
alice-blue 703495c
Merge pull request #8 from dfabulich/use-doSearch-for-newitems
alice-blue 157bf5f
searchutil.php: Add $count_all_possible_rows parameter to doSearch
alice-blue 310ebac
ifdb-recommends.php: Use $count_all_possible_rows parameter in call t…
alice-blue be1f667
review: Use $count_all_possible_rows parameter and $override_game_fil…
alice-blue 0954a8b
search: Use $count_all_possible_rows parameter in call to doSearch
alice-blue db7086a
editgame: Use $count_all_possible_rows and $override_game_filter para…
alice-blue 9bc40d4
length($rows) --> count($rows) (to get rid of fatal error)
alice-blue d016bac
searchutil.php: check for $term rather than a where clause to see if …
alice-blue 96bb618
Correctly exclude sandboxed ratings from `gameRatingsSandbox0`
dfabulich 02c69b3
Merge pull request #1264 from iftechfoundation/fix-sandbox-gameratings
dfabulich 801f985
searchutil.php: Fixed one more spot where we're checking `$where`
dfabulich d1942d8
Merge branch 'patch-2'
dfabulich 166f2f6
$where --> !$term
alice-blue b571fc5
Combine conditions & comments
alice-blue 8796aec
Merge branch 'main' into doSearch-need_total_rows-parameter
alice-blue 8f09857
search: Add a comment explaining the warning banner for buried games
dfabulich 0cbb32e
Merge pull request #1253 from iftechfoundation/search-numRatingsInAvg
dfabulich cb16a72
searchutil.php: Add $count_all_possible_rows parameter to doSearch
alice-blue 1e208ef
ifdb-recommends.php: Use $count_all_possible_rows parameter in call t…
alice-blue 404520b
review: Use $count_all_possible_rows parameter in call to doSearch
alice-blue 3a133f1
search: Use $count_all_possible_rows parameter in call to doSearch
alice-blue f91e3af
editgame: Use $count_all_possible_rows in call to doSearch
alice-blue 3342cf3
length($rows) --> count($rows) (to get rid of fatal error)
alice-blue ea64674
Improve logged-out IFDB Recommends search performance
dfabulich 27f50d3
Improve logged-in IFDB Recommends search performance
dfabulich f3d6803
Merge branch 'main' into filter-games-merged
dfabulich 663cef4
Merge branch 'ifdb-recommends-performance' into filter-games-merged
dfabulich 30cc954
Merge branch 'use-doSearch-for-newitems' into filter-games-merged
dfabulich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reasoning for this seems obscure enough that it might be worth explaining in a comment