Filter games merged #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to sort new items on the front page
`numRatingsInAvg` is what we display in search results. Querying a different number from what we display made the search results look wrong. Fixes iftechfoundation#1252
…-newitems Search results call it `devsys` instead of `system`
…ter in call to doSearch
…meters in call to doSearch
…we're searching or browsing
Prior to iftechfoundation#1256, we were excluding special reviews, embargoed reviews, and sandboxed reviews with a `where` clause, but this meant that some games were missing from `gameRatingsSandbox0`, when all of a game's reviews were special reviews. In iftechfoundation#1256, I removed the `where` clause and turned them into criteria on the `join` clauses. This worked fine for special reviews and embargoed reviews, but it didn't work for sandboxed reviews. We did a left join to the `users` table, excluding sandboxed users there, but we didn't use the results of that join. We never used `users.userid` for anything, and we never excluded any sandboxed reviews in the criteria for the `reviews` table. I've removed the join to `users` and replaced it with another criterion on the join to the `reviews` table, excluding reviews where the `userid` is sandboxed. I've confirmed that this still excludes special and embargoed reviews, and now it excludes sandboxed reviews, too. Also, I've confirmed that the number of rows matches the number of rows in the games table, so every game has a matching row in `gameRatingsSandbox0`. Fixes iftechfoundation#1263
…ndbox-gameratings Correctly exclude sandboxed ratings from `gameRatingsSandbox0`
…-numRatingsInAvg `#ratings:` search should use `numRatingsInAvg` not `numRatingsTotal`
This commit sets `$browse = 1`, which makes `searchutil.php` do an inner join to `gameRatingsSandbox0_mv`, allowing the query planner to grab the top N listings from the `starsort` index.
The query planner couldn't figure out how to handle joins with complex `on` filters, so I replaced them with `where gameid in` clauses for `played:` `willplay:` `wontplay:` `reviewed:` and `rated:` queries.
alice-blue
reviewed
Jan 22, 2025
| $maxpicks = 12; // Get the first twelve results. (We want extras so we're not always displaying the same games.) | ||
| $limit = "limit 0, $maxpicks"; | ||
| $browse = 0; | ||
| $browse = 1; |
There was a problem hiding this comment.
The reasoning for this seems obscure enough that it might be worth explaining in a comment
alice-blue
reviewed
Jan 22, 2025
| // table scan. If the total number of rows is not needed, we can skip | ||
| // `sql_calc_found_rows` to speed up the query. | ||
| $sql_calc_found_rows = ""; | ||
| } |
There was a problem hiding this comment.
I think 1123-1129 can be removed (this condition is accounted for in 1114)
There was a problem hiding this comment.
After merging your PR, I did another commit to delete those lines in the filter games 3 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main$count_all_possible_rowsparameter to doSearch iftechfoundation/ifdb#1265, resolving conflicts in favor of 1261With that done, the resulting branch seemed to work, and I found that the home page queries for new games, new reviews, and IFDB recommends were using fast index queries with and without a custom filter set for
-tag:sexual content.We can merge this into
filter-games-version-3at any time. Eventually, I'll merge 1265 and then 1196, at which point iftechfoundation#1199 will only show the new stuff.