Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9437] [ISSUE #9408] fix style NameSpaceList.js #9436

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

kunl
Copy link
Contributor

@kunl kunl commented Oct 31, 2022

修复样式,存在多行 namespace后,显示不全。

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

修复样式

Brief changelog

修复样式,存在多行 namespace后,显示不全。

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

修复样式,存在多行 namespace后,显示不全。
@CLAassistant
Copy link

CLAassistant commented Oct 31, 2022

CLA assistant check
All committers have signed the CLA.

@kunl kunl changed the title Update NameSpaceList.js Feat/bug fix style NameSpaceList.js Oct 31, 2022
@kunl kunl changed the title Feat/bug fix style NameSpaceList.js ISSUE#9437 fix style NameSpaceList.js Oct 31, 2022
@kunl kunl changed the title ISSUE#9437 fix style NameSpaceList.js [ISSUE #9437] fix style NameSpaceList.js Oct 31, 2022
@kunl
Copy link
Contributor Author

kunl commented Nov 1, 2022

#9408 #9437

@kunl kunl changed the title [ISSUE #9437] fix style NameSpaceList.js [ISSUE #9437] [ISSUE #9408] fix style NameSpaceList.js Nov 1, 2022
@KomachiSion KomachiSion added area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug. labels Nov 2, 2022
@KomachiSion KomachiSion added this to the 2.2.0 milestone Nov 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9436 (b0274cb) into develop (0a80276) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9436      +/-   ##
=============================================
- Coverage      47.57%   47.54%   -0.04%     
+ Complexity      4561     4560       -1     
=============================================
  Files            851      851              
  Lines          28298    28298              
  Branches        3193     3193              
=============================================
- Hits           13463    13453      -10     
- Misses         13600    13610      +10     
  Partials        1235     1235              
Impacted Files Coverage Δ
...ent/manager/impl/EphemeralIpPortClientManager.java 66.66% <0.00%> (-14.82%) ⬇️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 69.04% <0.00%> (-14.29%) ⬇️
...a/nacos/naming/healthcheck/HealthCheckReactor.java 70.00% <0.00%> (-10.00%) ⬇️
...os/common/trace/publisher/TraceEventPublisher.java 63.29% <0.00%> (+1.26%) ⬆️
...a/com/alibaba/nacos/core/remote/BaseRpcServer.java 89.47% <0.00%> (+26.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a80276...b0274cb. Read the comment docs.

@KomachiSion KomachiSion linked an issue Nov 3, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos console Related to Nacos consle kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

命名空间显示不全
4 participants