[ISSUE #9414] Optimize fuzzy queries to make SQL more general (#9428)

alibaba · Oct 31, 2022 · 0a80276 · 0a80276
1 parent 2596ff3
commit 0a80276
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...n/java/com/alibaba/nacos/plugin/auth/impl/persistence/ExternalRolePersistServiceImpl.java b/...n/java/com/alibaba/nacos/plugin/auth/impl/persistence/ExternalRolePersistServiceImpl.java
@@ -168,8 +168,8 @@ public void deleteRole(String role, String username) {
 
     @Override
     public List<String> findRolesLikeRoleName(String role) {
-        String sql = "SELECT role FROM roles WHERE role LIKE '%' ? '%'";
-        List<String> users = this.jt.queryForList(sql, new String[] {role}, String.class);
+        String sql = "SELECT role FROM roles WHERE role LIKE ?";
+        List<String> users = this.jt.queryForList(sql, new String[] {String.format("%%%s%%", role)}, String.class);
         return users;
     }
 

diff --git a/...n/java/com/alibaba/nacos/plugin/auth/impl/persistence/ExternalUserPersistServiceImpl.java b/...n/java/com/alibaba/nacos/plugin/auth/impl/persistence/ExternalUserPersistServiceImpl.java
@@ -162,8 +162,8 @@ public Page<User> getUsers(int pageNo, int pageSize, String username) {
 
     @Override
     public List<String> findUserLikeUsername(String username) {
-        String sql = "SELECT username FROM users WHERE username LIKE '%' ? '%'";
-        List<String> users = this.jt.queryForList(sql, new String[] {username}, String.class);
+        String sql = "SELECT username FROM users WHERE username LIKE ?";
+        List<String> users = this.jt.queryForList(sql, new String[]{String.format("%%%s%%", username)}, String.class);
         return users;
     }