Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#9210] ConnectionBasedClient support add revision #9239

Merged
merged 2 commits into from
Sep 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ public List<DistroData> getVerifyData() {
}
if (clientManager.isResponsibleClient(client)) {
DistroClientVerifyInfo verifyData = new DistroClientVerifyInfo(client.getClientId(),
client.recalculateRevision());
client.getRevision());
DistroKey distroKey = new DistroKey(client.getClientId(), TYPE);
DistroData data = new DistroData(distroKey,
ApplicationUtils.getBean(Serializer.class).serialize(verifyData));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public abstract class AbstractClient implements Client {

protected volatile long lastUpdatedTime;

private final AtomicLong revision;
protected final AtomicLong revision;

public AbstractClient(Long revision) {
lastUpdatedTime = System.currentTimeMillis();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,9 @@ public void setLastRenewTime() {
public boolean isExpire(long currentTime) {
return !isNative() && currentTime - getLastRenewTime() > ClientConfig.getInstance().getClientExpiredTime();
}

@Override
public long recalculateRevision() {
return revision.addAndGet(1);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
* @author : ChenHao26
* @ClassName: BatchInstancePublishInfo
* @Date: 2022/4/21 16:19
* @Description: TODO
*/
public class BatchInstancePublishInfo extends InstancePublishInfo {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,6 @@

import java.util.Collection;

/**
* AbstractClient test.
* @ClassName: AbstractClientTest
* @Author: ChenHao26
* @Date: 2022/8/3 16:22
* @Description: TODO
*/
@RunWith(MockitoJUnitRunner.class)
public class AbstractClientTest {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,6 @@

package com.alibaba.nacos.naming.core.v2.client;

/**
* Mock AbstractClient.
* @ClassName: MockAbstractClient
* @Author: ChenHao26
* @Date: 2022/8/3 16:25
* @Description: TODO
*/
public class MockAbstractClient extends AbstractClient {

public MockAbstractClient(Long revision) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@
import org.junit.Before;
import org.junit.Test;

import java.util.concurrent.TimeUnit;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertTrue;

public class ConnectionBasedClientTest {
Expand Down Expand Up @@ -47,4 +50,26 @@ public void testIsExpire() {
connectionBasedClient.getLastRenewTime() + 2 * ClientConfig.getInstance().getClientExpiredTime();
assertTrue(connectionBasedClient.isExpire(mustExpireTime));
}

@Test
public void testRecalculateRevision() {
assertEquals(0, connectionBasedClient.getRevision());
connectionBasedClient.recalculateRevision();
assertEquals(1, connectionBasedClient.getRevision());
}

@Test
public void testRecalculateRevisionAsync() throws InterruptedException {
assertEquals(0, connectionBasedClient.getRevision());
for (int i = 0; i < 10; i++) {
Thread thread = new Thread(() -> {
for (int j = 0; j < 10; j++) {
connectionBasedClient.recalculateRevision();
}
});
thread.start();
}
TimeUnit.SECONDS.sleep(1);
assertEquals(100, connectionBasedClient.getRevision());
}
}