Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#9210] ConnectionBasedClient support add revision #9239

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Fixes #9210.

Brief changelog

ConnectionBasedClient support add revision

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Sep 29, 2022
@KomachiSion KomachiSion added this to the 2.1.2 milestone Sep 29, 2022
@KomachiSion KomachiSion reopened this Sep 29, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9239 (f2b7cef) into develop (af22d35) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #9239      +/-   ##
=============================================
- Coverage      44.12%   44.08%   -0.05%     
- Complexity      4857     4858       +1     
=============================================
  Files            913      913              
  Lines          33048    33049       +1     
  Branches        3825     3825              
=============================================
- Hits           14583    14569      -14     
- Misses         17043    17059      +16     
+ Partials        1422     1421       -1     
Impacted Files Coverage Δ
...ephemeral/distro/v2/DistroClientDataProcessor.java 10.06% <0.00%> (ø)
...ba/nacos/naming/core/v2/client/AbstractClient.java 68.75% <ø> (ø)
.../naming/core/v2/pojo/BatchInstancePublishInfo.java 27.27% <ø> (ø)
...ing/core/v2/client/impl/ConnectionBasedClient.java 92.30% <100.00%> (+0.64%) ⬆️
...libaba/nacos/core/cluster/ServerMemberManager.java 72.17% <0.00%> (-4.79%) ⬇️
...os/client/auth/ram/identify/CredentialService.java 78.84% <0.00%> (-3.85%) ⬇️
...m/alibaba/nacos/core/remote/ConnectionManager.java 42.89% <0.00%> (-1.48%) ⬇️
...alibaba/nacos/core/remote/control/TpsRecorder.java 74.32% <0.00%> (-1.36%) ⬇️
.../core/v2/event/publisher/NamingEventPublisher.java 76.25% <0.00%> (+1.25%) ⬆️
...nacos/naming/core/v2/upgrade/UpgradeJudgement.java 80.00% <0.00%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af22d35...f2b7cef. Read the comment docs.

@pixystone
Copy link
Contributor

长连接的verify那边需不需要对比大小?更大的才是新的

@KomachiSion
Copy link
Collaborator Author

长连接的verify那边需不需要对比大小?更大的才是新的

不需要,肯定要以native的为准,

@chuntaojun chuntaojun merged commit f272c36 into alibaba:develop Sep 29, 2022
@KomachiSion KomachiSion deleted the develop-issue#9210 branch September 29, 2022 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using hash as revision for DISTRO data verification
4 participants