Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 2866 #3984

Merged
merged 18 commits into from
Oct 14, 2020
Merged

Fix issue 2866 #3984

merged 18 commits into from
Oct 14, 2020

Conversation

chuntaojun
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix issue #2892

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

chuntaojun added 18 commits June 17, 2020 15:20
@chuntaojun
improvement: merge upstream/develop
9585d55
@chuntaojun
refactor: merge upstream develop
29df82f
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
78167ab 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
7915e4f 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
9e7cf30 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
3d8b55c 
…evelop
@chuntaojun
feat: merge upstream develop
a07f84e
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
f181102 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
abee9c4 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
4dbd796 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
7455f51 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
63ac93b 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
b39970a 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
9aaea7f 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
0ee59bb 
…evelop
@chuntaojun
Merge branch 'develop' of https://github.com/alibaba/nacos into new_d…
756a0cc 
…evelop
@chuntaojun
Merge branch 'new_develop' of https://github.com/chuntaojun/nacos int…
2f93d35 
…o new_develop
@chuntaojun
fix: fix issue 2892
42064e0
@KomachiSion KomachiSion changed the title Fix issue 2892 Fix issue 2866 Oct 14, 2020
@KomachiSion KomachiSion linked an issue Oct 14, 2020 that may be closed by this pull request
Nacos permissions that this set here besides nacos account and other access is 403 / nacos/v1 / ns/operator/metrics #2866
Closed
@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Oct 14, 2020
@KomachiSion KomachiSion added this to the 1.4.0 milestone Oct 14, 2020
@KomachiSion KomachiSion added the kind/user experience not necessarily an error but can be improved for user experience label Oct 14, 2020
@KomachiSion KomachiSion merged commit b6bc4bb into alibaba:develop Oct 14, 2020
WesleyOne pushed a commit to WesleyOne/nacos that referenced this pull request Oct 20, 2020
@chuntaojun @WesleyOne
Fix issue 2866 (alibaba#3984)
d77392a 
* improvement: merge upstream/develop

* feat: merge upstream develop

* fix: fix issue 2892
loveincode added a commit to Framework-Source-Code/nacos that referenced this pull request Oct 21, 2020
@loveincode
Merge branch 'develop' of github.com:alibaba/nacos into develop
b33668f 
* 'develop' of github.com:alibaba/nacos: (678 commits)
  Fix integration test error
  Fix unit test error in ci
  For checkStyle
  Modify the startup script custom configuration first default configuration (alibaba#4021)
  Revert "Naming module Raft protocol migration"
  [ISSUE alibaba#3904] feature - operate instance's metadata alonely (alibaba#3912)
  For alibaba#3710#, Fix special characters cannot be used in Metadata (alibaba#4019)
  [ISSUE-alibaba#3855] Provided a feature to view version comparisons in the configDetails page (alibaba#3988)
  Refactor dispatch task execute (alibaba#3995)
  Revert "for alibaba#3621 (alibaba#3668)" (alibaba#3999)
  Naming module Raft protocol migration (alibaba#3989)
  refactor: code refactor
  [ISSUE alibaba#3576] [Enhancement] Adding the destroy lifecycle method on NamingMaintainService (alibaba#3985)
  Fix issue 2866 (alibaba#3984)
  For alibaba#3384, Fix member extend info do not update error. (alibaba#3982)
  Fix#3973 (alibaba#3974)
  Move remove listener logic to ServiceManager
  Move remove listener logic to ServiceManager
  1.fix unit test can't pass (alibaba#3956)
  [ISSUE alibaba#3909] add domain's judgement (alibaba#3913)
  ...
@snyk-bot snyk-bot mentioned this pull request Mar 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
kind/enhancement Category issues or prs related to enhancement. kind/user experience not necessarily an error but can be improved for user experience
Projects
None yet
Milestone
1.4.0
2 participants
@chuntaojun @KomachiSion