Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Adding the destroy lifecycle method on NamingMaintainService #3576

Closed
mercyblitz opened this issue Aug 11, 2020 · 4 comments · Fixed by #3985
Closed

[Enhancement] Adding the destroy lifecycle method on NamingMaintainService #3576

mercyblitz opened this issue Aug 11, 2020 · 4 comments · Fixed by #3985
Assignees
@realJackSun
Labels
contribution welcome kind/enhancement Category issues or prs related to enhancement.
Milestone
1.4.0

Comments

@mercyblitz
Copy link
Member

No description provided.

@KomachiSion KomachiSion added the kind/enhancement Category issues or prs related to enhancement. label Aug 11, 2020
@KomachiSion KomachiSion added this to the 1.4.0 milestone Aug 11, 2020
@KomachiSion
Copy link
Collaborator

Hi @mercyblitz , please edit your issue description with template. Thanks.

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@zongtanghu
Copy link
Collaborator

This issue can be assigned to me, firstly!I will resolve it. @KomachiSion @mercyblitz

@KomachiSion
Copy link
Collaborator

@zongtanghu No response and process from you for a long time, I unassigned you.

@KomachiSion KomachiSion self-assigned this Oct 13, 2020
@realJackSun
Copy link
Collaborator

@i will solve it@

@realJackSun realJackSun mentioned this issue Oct 13, 2020
Merged
5 tasks
realJackSun added a commit to realJackSun/nacos that referenced this issue Oct 13, 2020
@realJackSun
[ISSUE alibaba#3576] [Enhancement] Adding the destroy lifecycle metho…
935183e 
…d on NamingMaintainService
KomachiSion pushed a commit that referenced this issue Oct 14, 2020
@realJackSun
[ISSUE #3576] [Enhancement] Adding the destroy lifecycle method on Na…
7527d76 
…mingMaintainService (#3985)
WesleyOne pushed a commit to WesleyOne/nacos that referenced this issue Oct 20, 2020
@realJackSun @WesleyOne
[ISSUE alibaba#3576] [Enhancement] Adding the destroy lifecycle metho…
c57799c 
…d on NamingMaintainService (alibaba#3985)
loveincode added a commit to Framework-Source-Code/nacos that referenced this issue Oct 21, 2020
@loveincode
Merge branch 'develop' of github.com:alibaba/nacos into develop
b33668f 
* 'develop' of github.com:alibaba/nacos: (678 commits)
  Fix integration test error
  Fix unit test error in ci
  For checkStyle
  Modify the startup script custom configuration first default configuration (alibaba#4021)
  Revert "Naming module Raft protocol migration"
  [ISSUE alibaba#3904] feature - operate instance's metadata alonely (alibaba#3912)
  For alibaba#3710#, Fix special characters cannot be used in Metadata (alibaba#4019)
  [ISSUE-alibaba#3855] Provided a feature to view version comparisons in the configDetails page (alibaba#3988)
  Refactor dispatch task execute (alibaba#3995)
  Revert "for alibaba#3621 (alibaba#3668)" (alibaba#3999)
  Naming module Raft protocol migration (alibaba#3989)
  refactor: code refactor
  [ISSUE alibaba#3576] [Enhancement] Adding the destroy lifecycle method on NamingMaintainService (alibaba#3985)
  Fix issue 2866 (alibaba#3984)
  For alibaba#3384, Fix member extend info do not update error. (alibaba#3982)
  Fix#3973 (alibaba#3974)
  Move remove listener logic to ServiceManager
  Move remove listener logic to ServiceManager
  1.fix unit test can't pass (alibaba#3956)
  [ISSUE alibaba#3909] add domain's judgement (alibaba#3913)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realJackSun realJackSun

Labels
contribution welcome kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
1.4.0
4 participants
@mercyblitz @zongtanghu @KomachiSion @realJackSun