Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE 2989] where config publish could not trigger horizontal notification i… #2990

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

chuntaojun
Copy link
Collaborator

…n standalone + derby

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #2988 #2989

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@chuntaojun chuntaojun requested review from TsingLiang and yanlinly June 8, 2020 03:03
@chuntaojun chuntaojun added this to the 1.3.1 milestone Jun 8, 2020
@chuntaojun chuntaojun added area/Config kind/bug Category issues or prs related to bug. labels Jun 8, 2020
@chuntaojun chuntaojun linked an issue Jun 8, 2020 that may be closed by this pull request
KomachiSion
KomachiSion previously approved these changes Jun 8, 2020
@KomachiSion KomachiSion self-requested a review June 8, 2020 05:22
@KomachiSion KomachiSion dismissed their stale review June 8, 2020 05:26

something need to discuss again

@yanlinly yanlinly merged commit 5203ee3 into develop Jun 8, 2020
@chuntaojun chuntaojun deleted the hotfix_standalone_notify branch June 11, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
3 participants