-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix read file in jar 20190402 dq #646
Merged
sczyh30
merged 13 commits into
alibaba:master
from
dqing0:fix_readFileInJar_20190402_dq
Apr 15, 2019
Merged
Fix read file in jar 20190402 dq #646
sczyh30
merged 13 commits into
alibaba:master
from
dqing0:fix_readFileInJar_20190402_dq
Apr 15, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_readFileInJar_20190402_dq
Codecov Report
@@ Coverage Diff @@
## master #646 +/- ##
============================================
- Coverage 40.49% 40.47% -0.03%
+ Complexity 1187 1186 -1
============================================
Files 267 267
Lines 7845 7845
Branches 1061 1061
============================================
- Hits 3177 3175 -2
- Misses 4272 4274 +2
Partials 396 396
Continue to review full report at Codecov.
|
sczyh30
approved these changes
Apr 15, 2019
Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Fixes #634
Describe how you did it
1.参考FileRefreshableDataSource实现专门读取jar文件的方法
2.通过jdk的JarFile,和jarEntry读取jar包中的文件
Describe how to verify it
1.运行JarFileDataSourceDemo方法