Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read file in jar 20190402 dq #646

Merged
merged 13 commits into from
Apr 15, 2019

Conversation

dqing0
Copy link
Contributor

@dqing0 dqing0 commented Apr 2, 2019

Describe what this PR does / why we need it

Does this pull request fix one issue?

Fixes #634

Describe how you did it

1.参考FileRefreshableDataSource实现专门读取jar文件的方法
2.通过jdk的JarFile,和jarEntry读取jar包中的文件

Describe how to verify it

1.运行JarFileDataSourceDemo方法

@codecov-io
Copy link

codecov-io commented Apr 2, 2019

Codecov Report

Merging #646 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #646      +/-   ##
============================================
- Coverage     40.49%   40.47%   -0.03%     
+ Complexity     1187     1186       -1     
============================================
  Files           267      267              
  Lines          7845     7845              
  Branches       1061     1061              
============================================
- Hits           3177     3175       -2     
- Misses         4272     4274       +2     
  Partials        396      396
Impacted Files Coverage Δ Complexity Δ
...s/block/flow/controller/RateLimiterController.java 79.31% <0%> (-10.35%) 7% <0%> (-1%)
...l/cluster/server/connection/ConnectionManager.java 76% <0%> (+2%) 11% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f20899...2dd5f4a. Read the comment docs.

@sczyh30 sczyh30 added the to-review To review label Apr 2, 2019
@sczyh30 sczyh30 merged commit 882a060 into alibaba:master Apr 15, 2019
@sczyh30
Copy link
Member

sczyh30 commented Apr 15, 2019

Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileWritableDataSource :file:/xx/xx.jar!/BOOT-INF/classes!/FlowRule.json (no such file or directory)
3 participants