Skip to content

[BUGFIX] Expose the correct external IP of GIE. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 7, 2021

Conversation

lidongze0629
Copy link
Collaborator

What do these changes do?

  • Check GIE gremlin service external ip is null by for loop.
  • fix the stream log failed problem when the GIE manager image is not exist.

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #69 (704515a) into main (5c9a222) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   78.04%   78.01%   -0.04%     
==========================================
  Files          49       49              
  Lines        4473     4475       +2     
==========================================
  Hits         3491     3491              
- Misses        982      984       +2     
Impacted Files Coverage Δ
python/graphscope/deploy/kubernetes/cluster.py 73.70% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c9a222...704515a. Read the comment docs.

@yecol yecol changed the title Some fixes before release: Get GIE gremlin external ip correctly. [BUGFIX] Expose the correct external IP of GIE. Jan 6, 2021
@lidongze0629 lidongze0629 merged commit 0915a56 into alibaba:main Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants