[BUGFIX] Expose the correct external IP of GIE. (#69)

* Check external-ip is null by for loop
* Skip checking instance ready when localhost.

Author: lidongze0629

coordinator/gscoordinator/coordinator.py

@@ -157,15 +157,22 @@ def __del__(self):
         self._cleanup()
 
     def _config_logging(self, log_level):
-        if log_level:
-            log_level = getattr(logging, log_level.upper(), logging.INFO)
-        else:
-            log_level = logging.INFO
-        logging.getLogger("graphscope").setLevel(log_level)
-        logging.basicConfig(
-            format="%(asctime)s [%(levelname)s][%(module)s:%(lineno)d]: %(message)s",
-            stream=sys.stdout,
+        """Set log level basic on config.
+        Args:
+            log_level (str): Log level of stdout handler
+        """
+        logger = logging.getLogger("graphscope")
+        logger.setLevel(logging.DEBUG)
+
+        stdout_handler = logging.StreamHandler(sys.stdout)
+        stdout_handler.setLevel(log_level)
+
+        formatter = logging.Formatter(
+            "%(asctime)s [%(levelname)s][%(module)s:%(lineno)d]: %(message)s"
         )
+        stdout_handler.setFormatter(formatter)
+
+        logger.addHandler(stdout_handler)
 
     def ConnectSession(self, request, context):
         # A session is already connected.

coordinator/gscoordinator/template/CMakeLists.template

@@ -3,7 +3,7 @@
 ###############################################################################
 
 project(example C CXX)
-cmake_minimum_required(VERSION 2.8)
+cmake_minimum_required(VERSION 3.5)
 
 option(CYTHON_PREGEL_APP "Whether to build cython pregel app." False)
 option(CYTHON_PIE_APP "Whether to build cython pie app" False)

interactive_engine/deploy/docker/dockerfile/create_maxgraph_instance.sh

@@ -13,6 +13,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 source /root/maxgraph/func.sh
+timeout_seconds=60
+
 function _create_maxgraph_instance {
     _setup_config
     # launch coordinator & frontend in one pod
@@ -67,7 +69,20 @@ function _expose_gremlin_server {
         kubectl expose pod ${gremlin_pod} --name=gremlin-${object_id} --port=${external_port} \
             --target-port=${port} --type=LoadBalancer 1>/dev/null 2>&1
         [ $? -eq 0 ] || exit 1
-        EXTERNAL_IP=`kubectl describe service gremlin-${object_id} | grep "LoadBalancer Ingress" | awk -F'[ :]+' '{print $3}'`
+        wait_period_seconds=0
+        while true
+        do
+            EXTERNAL_IP=`kubectl describe service gremlin-${object_id} | grep "LoadBalancer Ingress" | awk -F'[ :]+' '{print $3}'`
+            if [ -n "${EXTERNAL_IP}" ]; then
+                break
+            fi
+            wait_period_seconds=$(($wait_period_seconds+5))
+            if [ ${wait_period_seconds} -gt ${timeout_seconds} ];then
+                echo "Get external ip of ${GREMLIN_EXPOSE} failed."
+                break
+            fi
+            sleep 5
+        done
     else
         kubectl expose pod ${gremlin_pod} --name=gremlin-${object_id} --port=${port} \
             --target-port=${port} --type=NodePort 1>/dev/null 2>&1

interactive_engine/src/instance-manager/src/main/java/com/alibaba/maxgraph/admin/controller/InstanceManagerController.java

@@ -161,6 +161,11 @@ public CreateInstanceEntity createInstance(@RequestParam("graphName") String gra
     }
 
     private boolean checkInstanceReady(String ip, int port) {
+        if (ip.equals("localhost") || ip.equals("127.0.0.1")) {
+            // now, used in mac os with docker-desktop kubernetes cluster,
+            // which external ip is 'localhost' when service type is 'LoadBalancer'.
+            return true;
+        }
         MessageSerializer serializer = Serializers.GRYO_V1D0.simpleInstance();
         Map<String, Object> config = new HashMap<String, Object>() {
             {

k8s/graphscope.Dockerfile

@@ -57,7 +57,7 @@ RUN export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/opt/graphscope/lib:/opt/graphscope/
     pip3 install -r requirements.txt -r requirements-dev.txt && \
     python3 setup.py bdist_wheel && \
     cd ./dist && \
-    auditwheel repair --plat=manylinux2014_x86_64 ./*.whl && \
+    auditwheel repair --plat=manylinux2014_x86_64 ./*.whl || true && \
     cp ./wheelhouse/* /opt/graphscope/dist/ && \
     cd /root/gs/coordinator && \
     pip3 install -r requirements.txt -r requirements-dev.txt && \

python/graphscope/deploy/kubernetes/cluster.py

@@ -450,7 +450,12 @@ def _waiting_for_services_ready(self):
 
         for pod in pods.items:
             self._coordinator_pods_watcher.append(
-                KubernetesPodWatcher(self._api_client, self._namespace, pod)
+                KubernetesPodWatcher(
+                    self._api_client,
+                    self._namespace,
+                    pod,
+                    self._coordinator_container_name,
+                )
             )
             self._coordinator_pods_watcher[-1].start()
 
@@ -532,6 +537,9 @@ def _dump_coordinator_failed_status(self):
                         break
                     else:
                         logger.error(message, extra={"simple": True})
+        else:
+            for pod_watcher in self._coordinator_pods_watcher:
+                pod_watcher.stop()
 
     def start(self):
         """Launch graphscope instance on kubernetes cluster.