ABI: Refactor ABI encoding test to round-trip#701
Merged
Conversation
algochoi
reviewed
Nov 30, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Looks like a good improvement, just want to check a testcase for something like tuple(int)
algochoi
approved these changes
Nov 30, 2022
algochoi
added a commit
that referenced
this pull request
Jan 18, 2023
* ABI: Refactor ABI encoding test to round-trip (#701) * bump version and add to changelog * update README.md for new version * Packaging: Improve source map and browser usage for external bundlers (#707) * bump version and add to changelog * update README.md for new version * v2: Make breaking changes from v1 to v2.0.0 (#717) * bump version and add to changelog * update README.md for new version * remove enhancement section of recent changelog * Enhancement: Add foreign array objects to ATC `addMethodCall` (#725) * Add foreign array objects to ATC addmethodcall * Copy array value so that inputs are not modified Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Lucky Baar <lucky.baar@algorand.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com> Co-authored-by: Jack Smith <jack.smith@algorand.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com>
algochoi
added a commit
that referenced
this pull request
Jan 18, 2023
* Add test for algod /v2/teal/disassemble * Merge develop into PR (#736) * ABI: Refactor ABI encoding test to round-trip (#701) * bump version and add to changelog * update README.md for new version * Packaging: Improve source map and browser usage for external bundlers (#707) * bump version and add to changelog * update README.md for new version * v2: Make breaking changes from v1 to v2.0.0 (#717) * bump version and add to changelog * update README.md for new version * remove enhancement section of recent changelog * Enhancement: Add foreign array objects to ATC `addMethodCall` (#725) * Add foreign array objects to ATC addmethodcall * Copy array value so that inputs are not modified Co-authored-by: Michael Diamant <michaeldiamant@users.noreply.github.com> Co-authored-by: Lucky Baar <lucky.baar@algorand.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com> Co-authored-by: Jack Smith <jack.smith@algorand.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com> * Explicitly import Buffer * Revert test branch back to master Co-authored-by: algochoi <86622919+algochoi@users.noreply.github.com> Co-authored-by: Lucky Baar <lucky.baar@algorand.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com> Co-authored-by: Jack Smith <jack.smith@algorand.com> Co-authored-by: Barbara Poon <barbara.poon@algorand.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #700, the PR replaces discrete encode and decode tests with a single test performing a round-trip encoding-decoding-encoding.
The intent is to:
Additionally, the PR refactors towards dynamically generated tests (https://mochajs.org/#dynamically-generating-tests) so that individual test case failures can be observed.