Bug-Fix: encode ABI string with non-ASCII characters#700
Merged
Conversation
ahangsu
requested review from
algochoi,
bbroder-algo,
jasonpaulos and
michaeldiamant
ahangsu
force-pushed
the
utf-8-string-abi
branch
from
847b6fe to
4c2afb1
Compare
algochoi
reviewed
Nov 29, 2022
Contributor
algochoi
left a comment
algochoi
left a comment
There was a problem hiding this comment.
Looking good - nit: I'd also test something like "⚽ 🏃" just so it's a bit clearer we are testing for non-ascii characters like emojis
Contributor
Author
|
makes sense, I will add new case once this build passes |
michaeldiamant
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #699