Enhancement: Code generation improvements#663
Merged
Conversation
algochoi
approved these changes
Oct 12, 2022
Contributor
algochoi
left a comment
There was a problem hiding this comment.
Looks good - is our new approach to always use generated models for algod/indexer responses going forward?
Contributor
Author
|
Generally speaking, yes, I think we should add a js-algorand-sdk/src/client/v2/algod/getApplicationBoxByName.ts Lines 45 to 48 in c104590 |
michaeldiamant
approved these changes
Oct 12, 2022
Contributor
michaeldiamant
left a comment
There was a problem hiding this comment.
I visually spot-checked several generated examples confirming they match the OpenAPI specification + existing parts of the repo.
ahangsu
approved these changes
Oct 12, 2022
This was referenced Nov 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains improvements from algorand/generator#42.