TypeScript improvements#42
Merged
Merged
Conversation
This was referenced Sep 29, 2022
jasonpaulos
commented
Sep 29, 2022
winder
approved these changes
Oct 4, 2022
Contributor
winder
left a comment
There was a problem hiding this comment.
These changes look fine to me. Presumably you're happy with the generated code, so I don't see any reason not to merge this.
Contributor
|
Since @jasonpaulos is OOO for the week, leaving a note to broadcast sequencing suggestion:
|
michaeldiamant
approved these changes
Oct 12, 2022
Contributor
michaeldiamant
left a comment
There was a problem hiding this comment.
My approval is primarily driven by review of generated changes in algorand/js-algorand-sdk#663.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves TypeScript generation in a few ways:
fromParsedJSONhas been added to each generated model class. This method allows JSON responses to be turned into our generated class types.number | bigint[], but they are now correctly built as(number | bigint)[].The changes here were used to generate the code in algorand/js-algorand-sdk#663 and algorand/js-algorand-sdk#662