-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Python Test for Generated Files #829
Create Python Test for Generated Files #829
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the test so that we don't need to update the md5 file? i.e. create it before running go generate
and check that the file wasn't modified afterward.
The CI script also needs to be updated to call the new script.
Also please move this to the misc
directory.
Resolves #405 Adds a python script that can be used to test that go generate did not modify any files
ce9a520
to
faf764f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #829 +/- ##
========================================
Coverage 59.31% 59.31%
========================================
Files 32 32
Lines 4095 4095
========================================
Hits 2429 2429
Misses 1368 1368
Partials 298 298 Continue to review full report at Codecov.
|
cb4e702
to
c3e6541
Compare
53987aa
to
02240f3
Compare
list_of_directories=["../idb/postgres/internal/schema"] | ||
|
||
for dir in list_of_directories: | ||
os.system("/usr/local/go/bin/go generate {}".format(dir)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work without specifying the full path to go
? It needs to be on the path for everything else so I think it's a fair assumption as long as it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does not work without it unfortunately
Resolves #405
Adds a python script that can be used to test that go generate did not
modify any files