Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration test for generated files #405

Closed
brianolson opened this issue Mar 26, 2021 · 0 comments · Fixed by #829
Closed

integration test for generated files #405

brianolson opened this issue Mar 26, 2021 · 0 comments · Fixed by #829
Assignees
@AlgoStephenAkiki
Labels
Team Lamprey tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead

Comments

@brianolson
Copy link
Contributor

brianolson commented Mar 26, 2021 •
edited by AlgoStephenAkiki
Loading

Summary

To ensure that development doesn't make generated files out of sync with their sources, write an integration test that checks that generation produces no change.

Scope/Requirements

idb/postgres/postgres.go:7 //go:generate go run ../../cmd/texttosource/main.go postgres setup_postgres.sql reset.sql

Urgency/Relative Priority

medium. editing setup_postgres.sql isn't too common.
@winder winder added the tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead label Apr 30, 2021
@winder winder added Team Lamprey and removed FDE labels Jan 18, 2022
@AlgoStephenAkiki AlgoStephenAkiki mentioned this issue Jan 19, 2022
Merged
AlgoStephenAkiki added a commit that referenced this issue Jan 20, 2022
@AlgoStephenAkiki
Create Python Test for Generated Files
faf764f 
Resolves #405

Adds a python script that can be used to test that go generate did not
modify any files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlgoStephenAkiki AlgoStephenAkiki

Labels
Team Lamprey tech debt Things that need re-work for simplification / sanitization to reduce implementation overhead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create Python Test for Generated Files algorand/indexer
4 participants
@winder @brianolson @ian-algorand @AlgoStephenAkiki