-
Notifications
You must be signed in to change notification settings - Fork 93
filter-plugin: Inner Txn support. #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
558a5a9
Switch from SignedTxnInBlock to SignedTxnWithAD.
winder c4293a0
Reduce scope of SearchAndFilter
winder daa3212
combine different match types.
winder 5d5f3e8
Rename Search to Match
winder 7b7884a
Rename things.
winder 87271cb
Add inner transaction search.
winder 43e9316
Linter warning.
winder 9f9cc07
Add inner txn search test.
winder 5bf94e6
misc
winder 92cc32b
Ignore the generated file in codecov report.
winder e405cac
Update benchmark to see impact of inner transactions.
winder e19f869
String equality is about 10% faster than regex matching.
winder 1c8505f
Move search inner filter to top level.
winder 385fb5a
New unit test.
winder 0a41da9
Subset is not as strict as I was thinking.
winder b9b9023
Move regex error checking.
winder 248205e
Fix comment
winder 2cfe74f
Merge branch 'develop' into will/filter-inner-txn
winder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously this was using a special regex expression. In benchmarks using string equals was 8-12% faster.