filter-plugin: Inner Txn support. #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winder
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1487 +/- ##
===========================================
+ Coverage 65.39% 66.28% +0.89%
===========================================
Files 82 81 -1
Lines 11458 11260 -198
===========================================
- Hits 7493 7464 -29
+ Misses 3393 3226 -167
+ Partials 572 570 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Benchmark results |
winder
commented
Mar 1, 2023
Comment on lines
+59
to
+70
| type stringEqualExpression struct { | ||
| Str string | ||
| } | ||
|
|
||
| func (e *stringEqualExpression) Match(input interface{}) (bool, error) { | ||
| switch v := input.(type) { | ||
| case string: | ||
| return e.Str == v, nil | ||
| default: | ||
| return false, fmt.Errorf("unexpected regex search input type (%T)", v) | ||
| } | ||
| } |
There was a problem hiding this comment.
Previously this was using a special regex expression. In benchmarks using string equals was 8-12% faster.
winder
commented
Mar 1, 2023
| fields, errors := getFields(sdk.SignedTxnInBlock{}, ignoreTags) | ||
| fields, errors := getFields(sdk.SignedTxnWithAD{}, ignoreTags) |
There was a problem hiding this comment.
Switched to SignedTxnWithAD because that is the type used for inner transactions. This way the same lookup function is used for the root transaction and the inner transactions.
Eric-Warehime
approved these changes
Mar 1, 2023
conduit/plugins/processors/filterprocessor/fields/searcher_test.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SignedTxnWithADinstead ofSignedTxnInBlock.matchesfunction from SearchAndFilter to avoid duplicate code for operation types (any/all/none).SearchtoMatchfor lowest level expressions.FilterTypetoType.Filterfrom theFilterconstants, it is in their type.searchfunction in theSearchertype. It now has an option to recursively search inner transactions for a match.Test Plan
New unit test.
Updated benchmarks.