Skip to content

agreement: Fix for missing votes telemetry with logging level less than info #6447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
algorandskiy merged 1 commit into from
Oct 1, 2025
Merged

agreement: Fix for missing votes telemetry with logging level less than info #6447

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions agreement/pseudonode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,23 +415,25 @@ func (t pseudonodeVotesTask) execute(verifier *AsyncVoteVerifier, quit chan stru
for _, result := range verifiedResults {
totalWeight += result.v.Cred.Weight
}
if t.node.log.IsLevelEnabled(logging.Info) {
if t.node.log.IsLevelEnabled(logging.Info) || t.node.log.GetTelemetryEnabled() {
for _, result := range verifiedResults {
vote := result.v
logEvent := logspec.AgreementEvent{
Type: logspec.VoteBroadcast,
Sender: vote.R.Sender.String(),
Hash: vote.R.Proposal.BlockDigest.String(),
Round: uint64(t.round),
Period: uint64(t.period),
Step: uint64(t.step),
ObjectRound: uint64(vote.R.Round),
ObjectPeriod: uint64(vote.R.Period),
ObjectStep: uint64(vote.R.Step),
Weight: vote.Cred.Weight,
WeightTotal: totalWeight,
if t.node.log.IsLevelEnabled(logging.Info) {
logEvent := logspec.AgreementEvent{
Type: logspec.VoteBroadcast,
Sender: vote.R.Sender.String(),
Hash: vote.R.Proposal.BlockDigest.String(),
Round: uint64(t.round),
Period: uint64(t.period),
Step: uint64(t.step),
ObjectRound: uint64(vote.R.Round),
ObjectPeriod: uint64(vote.R.Period),
ObjectStep: uint64(vote.R.Step),
Weight: vote.Cred.Weight,
WeightTotal: totalWeight,
}
t.node.log.with(logEvent).Infof("vote created for broadcast (weight %d, total weight %d)", vote.Cred.Weight, totalWeight)
}
t.node.log.with(logEvent).Infof("vote created for broadcast (weight %d, total weight %d)", vote.Cred.Weight, totalWeight)
if !t.node.log.GetTelemetryEnabled() {
continue
}
Expand All @@ -445,7 +447,9 @@ func (t pseudonodeVotesTask) execute(verifier *AsyncVoteVerifier, quit chan stru
// Recovered: false,
})
}
t.node.log.Infof("pseudonode.makeVotes: %v votes created for %v at (%v, %v, %v), total weight %v", len(verifiedResults), t.prop, t.round, t.period, t.step, totalWeight)
if t.node.log.IsLevelEnabled(logging.Info) {
t.node.log.Infof("pseudonode.makeVotes: %v votes created for %v at (%v, %v, %v), total weight %v", len(verifiedResults), t.prop, t.round, t.period, t.step, totalWeight)
Comment thread
algorandskiy marked this conversation as resolved.
}
}
Comment thread
cce marked this conversation as resolved.
if len(verifiedResults) > 0 {
// wait until the persist state is flushed, as we don't want to send any vote unless we've completed flushing it to disk.
Expand Down
Loading