Skip to content

agreement: Fix for missing votes telemetry with logging level less than info#6447

Merged
algorandskiy merged 1 commit intoalgorand:masterfrom
dragmz:telemetry-votes-fix
Oct 1, 2025
Merged

agreement: Fix for missing votes telemetry with logging level less than info#6447
algorandskiy merged 1 commit intoalgorand:masterfrom
dragmz:telemetry-votes-fix

Conversation

@dragmz
Copy link
Copy Markdown
Contributor

@dragmz dragmz commented Sep 25, 2025

Summary

This fixes missing votes telemetry with the telemetry enabled but logging level set to less than info level.

Test Plan

Verified by building and running the node on the mainnet. BaseLoggerDebugLevel = 0, telemetry enabled, checked votes on the Nodely dashboard.

@algorandskiy algorandskiy requested a review from cce September 30, 2025 20:03
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.72%. Comparing base (c2bb30f) to head (adb44c1).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6447      +/-   ##
==========================================
- Coverage   50.89%   50.72%   -0.17%     
==========================================
  Files         665      658       -7     
  Lines      111544   111450      -94     
==========================================
- Hits        56767    56531     -236     
- Misses      51904    52042     +138     
- Partials     2873     2877       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread agreement/pseudonode.go
@cce cce changed the title Fix for missing votes telemetry with logging level less than info agreement: Fix for missing votes telemetry with logging level less than info Sep 30, 2025
@cce cce requested a review from Copilot September 30, 2025 21:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes missing votes telemetry when logging level is set below info level but telemetry is enabled. The issue occurred because telemetry collection was previously conditional on the info logging level being enabled.

  • Separates logging from telemetry collection logic by adding telemetry check to the main conditional
  • Wraps info-level logging statements in separate conditional checks
  • Ensures votes telemetry is collected regardless of logging level when telemetry is enabled

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread agreement/pseudonode.go
@algorandskiy algorandskiy merged commit a65b0f7 into algorand:master Oct 1, 2025
39 of 42 checks passed
cce added a commit to cce/go-algorand that referenced this pull request Oct 7, 2025
@dragmz dragmz deleted the telemetry-votes-fix branch November 19, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants