agreement: Fix for missing votes telemetry with logging level less than info#6447
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom Oct 1, 2025
Merged
Conversation
algorandskiy
approved these changes
Sep 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6447 +/- ##
==========================================
- Coverage 50.89% 50.72% -0.17%
==========================================
Files 665 658 -7
Lines 111544 111450 -94
==========================================
- Hits 56767 56531 -236
- Misses 51904 52042 +138
- Partials 2873 2877 +4 ☔ View full report in Codecov by Sentry. |
cce
reviewed
Sep 30, 2025
cce
approved these changes
Sep 30, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes missing votes telemetry when logging level is set below info level but telemetry is enabled. The issue occurred because telemetry collection was previously conditional on the info logging level being enabled.
- Separates logging from telemetry collection logic by adding telemetry check to the main conditional
- Wraps info-level logging statements in separate conditional checks
- Ensures votes telemetry is collected regardless of logging level when telemetry is enabled
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
cce
added a commit
to cce/go-algorand
that referenced
this pull request
Oct 7, 2025
… less than info (algorand#6447)" This reverts commit a65b0f7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes missing votes telemetry with the telemetry enabled but logging level set to less than info level.
Test Plan
Verified by building and running the node on the mainnet. BaseLoggerDebugLevel = 0, telemetry enabled, checked votes on the Nodely dashboard.