Skip to content

tests: network flaky tests fixes#6407

Merged
cce merged 4 commits intoalgorand:masterfrom
algorandskiy:pavel/network-timeout-test-fixes
Aug 5, 2025
Merged

tests: network flaky tests fixes#6407
cce merged 4 commits intoalgorand:masterfrom
algorandskiy:pavel/network-timeout-test-fixes

Conversation

@algorandskiy
Copy link
Copy Markdown
Contributor

Summary

wsNetwork tests: increase wait ready timeout to 5s
TestP2PwsStreamHandlerDedup: relax wait condition to handle occasional disconnects
TestNodeHybridTopology: add debug output

Test Plan

These are test fixes

Sometimes peer disconnects with "read err: EOF" that forces
reconnection and the counter assumption is off by 1
@cce cce requested a review from Copilot August 5, 2025 20:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses network-related test flakiness by making test conditions more robust and adding debugging capabilities.

  • Increased WebSocket network ready timeout from 2 to 5 seconds
  • Relaxed assertion condition in P2P stream handler deduplication test to handle occasional disconnects
  • Added debug logging to hybrid topology test for troubleshooting connection issues

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
network/wsNetwork_test.go Increased ready timeout to reduce flaky timeouts
network/p2pNetwork_test.go Relaxed disconnect count assertion to handle variability
node/node_test.go Added debug output for connection diagnostics

Comment thread node/node_test.go
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.47%. Comparing base (e11f501) to head (f6e986a).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6407      +/-   ##
==========================================
- Coverage   50.66%   50.47%   -0.19%     
==========================================
  Files         661      654       -7     
  Lines      110781   110683      -98     
==========================================
- Hits        56122    55868     -254     
- Misses      51793    51935     +142     
- Partials     2866     2880      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cce cce merged commit 1d39d70 into algorand:master Aug 5, 2025
39 checks passed
@algorandskiy algorandskiy deleted the pavel/network-timeout-test-fixes branch March 16, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants