Skip to content

API: Apply revert box API changes done in #6343 to 4.1.x hotfix line#6345

Closed
gmalouf wants to merge 2 commits into4_1_x-hotfixfrom
4_1_x-box-api-revert
Closed

API: Apply revert box API changes done in #6343 to 4.1.x hotfix line#6345
gmalouf wants to merge 2 commits into4_1_x-hotfixfrom
4_1_x-box-api-revert

Conversation

@gmalouf
Copy link
Copy Markdown
Contributor

@gmalouf gmalouf commented May 29, 2025

Summary

See #6343 - this PR applies those equivalent changes (through reverts of the original PRs in this release) to a hotfix branch in prep for a hotfix release.

Test Plan

All existing tests should pass.

@gmalouf gmalouf self-assigned this May 29, 2025
@gmalouf gmalouf changed the base branch from master to 4_1_x-hotfix May 29, 2025 03:12
@codecov
Copy link
Copy Markdown

codecov bot commented May 29, 2025

Codecov Report

Attention: Patch coverage is 36.61972% with 90 lines in your changes missing coverage. Please review.

Project coverage is 51.93%. Comparing base (d7a2182) to head (aab5b35).

Files with missing lines Patch % Lines
ledger/acctupdates.go 62.29% 18 Missing and 5 partials ⚠️
daemon/algod/api/server/v2/handlers.go 29.62% 19 Missing ⚠️
ledger/store/trackerdb/sqlitedriver/sql.go 12.50% 14 Missing ⚠️
...edger/store/trackerdb/generickv/accounts_reader.go 0.00% 12 Missing ⚠️
...dger/store/trackerdb/dualdriver/accounts_reader.go 0.00% 9 Missing ⚠️
cmd/goal/box.go 11.11% 8 Missing ⚠️
daemon/algod/api/client/restClient.go 0.00% 2 Missing ⚠️
libgoal/libgoal.go 0.00% 2 Missing ⚠️
cmd/goal/account.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           4_1_x-hotfix    #6345      +/-   ##
================================================
- Coverage         52.07%   51.93%   -0.15%     
================================================
  Files               660      653       -7     
  Lines             87632    87539      -93     
================================================
- Hits              45630    45459     -171     
- Misses            39150    39208      +58     
- Partials           2852     2872      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmalouf
Copy link
Copy Markdown
Contributor Author

gmalouf commented May 29, 2025

Closing in favor of #6347

@gmalouf gmalouf closed this May 29, 2025
@gmalouf gmalouf deleted the 4_1_x-box-api-revert branch June 3, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant