API: Revert boxes pagination

[gmalouf]

Summary

This reverts #6279. Introducing box pagination as done in that PR broke an implicit contract that impacts enough users to warrant a (future) new endpoint:

Callers should be especially aware that the round will not be the latest round. Results are returned from the last round that was committed to the DB. Usually, that's four rounds old.

After additional feedback from users, we are taking the short term step of reverting the existing endpoint enhancements. A future PR may add pagination functionality, on an endpoint/sub-endpoint that does not impact the existing userbase.

Test Plan

Existing tests should all pass.

[codecov]

Codecov Report

Attention: Patch coverage is 36.61972% with 90 lines in your changes missing coverage. Please review.

Project coverage is 51.96%. Comparing base (5ea77f2) to head (d347326).
Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
ledger/acctupdates.go	62.29%	18 Missing and 5 partials ⚠️
daemon/algod/api/server/v2/handlers.go	30.76%	18 Missing ⚠️
ledger/store/trackerdb/sqlitedriver/sql.go	12.50%	14 Missing ⚠️
...edger/store/trackerdb/generickv/accounts_reader.go	0.00%	12 Missing ⚠️
cmd/goal/box.go	10.00%	9 Missing ⚠️
...dger/store/trackerdb/dualdriver/accounts_reader.go	0.00%	9 Missing ⚠️
daemon/algod/api/client/restClient.go	0.00%	2 Missing ⚠️
libgoal/libgoal.go	0.00%	2 Missing ⚠️
cmd/goal/account.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6343      +/-   ##
==========================================
+ Coverage   51.90%   51.96%   +0.05%     
==========================================
  Files         653      653              
  Lines       87469    87460       -9     
==========================================
+ Hits        45401    45447      +46     
+ Misses      39198    39139      -59     
- Partials     2870     2874       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[algorandskiy]

I reviewed the key files (i.e. excl. tests) and it is LGTM

[cce]

To aid in review, I created a branch with the three PR commits reverted here omitted, using git rebase:
https://github.com/gmalouf/go-algorand/compare/revert-boxes-pagination..cce:go-algorand:rebuild-revert-6343
https://github.com/cce/go-algorand/compare/rebuild-revert-6343..gmalouf:go-algorand:revert-boxes-pagination

(important to use a .. diff instead of a ... diff to avoid including other commits on master not related)

The diff looks good!