tests: fix TestP2PEnableGossipService_BothDisable#6320
Merged
algorandskiy merged 1 commit intoalgorand:masterfrom May 9, 2025
Merged
tests: fix TestP2PEnableGossipService_BothDisable#6320algorandskiy merged 1 commit intoalgorand:masterfrom
algorandskiy merged 1 commit intoalgorand:masterfrom
Conversation
gmalouf
approved these changes
May 9, 2025
onetechnical
approved these changes
May 9, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6320 +/- ##
==========================================
- Coverage 51.86% 51.85% -0.02%
==========================================
Files 652 652
Lines 87437 87442 +5
==========================================
- Hits 45350 45339 -11
- Misses 39222 39239 +17
+ Partials 2865 2864 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After merging #6308 the TestP2PEnableGossipService_BothDisable test became unstable because of a race condition between the check in the test and closing connection in
CloseWithoutFlush.Fixed by manually subscribing to
Connectednotification to make sure connections were made but still no peers due toEnableGossipService=falseoption.Test Plan
This is a test fix