network: close p2p conn in CloseWithoutFlush#6308
Merged
algorandskiy merged 2 commits intoalgorand:masterfrom May 9, 2025
Merged
network: close p2p conn in CloseWithoutFlush#6308algorandskiy merged 2 commits intoalgorand:masterfrom
algorandskiy merged 2 commits intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6308 +/- ##
==========================================
- Coverage 51.60% 51.58% -0.02%
==========================================
Files 649 649
Lines 87013 87017 +4
==========================================
- Hits 44903 44892 -11
- Misses 39244 39259 +15
Partials 2866 2866 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jannotti
reviewed
Apr 24, 2025
jannotti
approved these changes
May 6, 2025
cce
approved these changes
May 9, 2025
This was referenced May 15, 2025
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Out P2P implementation does not close p2p connections so it is possible non-performant peers still have open service streams (incl. DHT and pubsub).
Test Plan
Existing tests