test: fix flaky TestExactAccountChunk again#6278
Merged
algorandskiy merged 2 commits intoalgorand:masterfrom Mar 17, 2025
Merged
test: fix flaky TestExactAccountChunk again#6278algorandskiy merged 2 commits intoalgorand:masterfrom
algorandskiy merged 2 commits intoalgorand:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6278 +/- ##
==========================================
+ Coverage 51.63% 51.66% +0.03%
==========================================
Files 647 647
Lines 86907 86907
==========================================
+ Hits 44876 44903 +27
+ Misses 39161 39136 -25
+ Partials 2870 2868 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
algorandskiy
approved these changes
Mar 16, 2025
gmalouf
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I recently this test fail on an unrelated PR:
It seems the issue is that in #6214, I added an assertion that the DoubleLedger's two ledgers had committed the same round (on the rnd returned by
testCatchpointFlushRound) BEFORE the code added to address flakiness in #5993 and wait until the two ledgers were caught up and in sync. (It makes sense that this 300-round subtest is the one that failed, since there were more rounds waiting to be flushed.) This moves the assertion after the fix in #5993.Test Plan
Existing test should pass, and hopefully not occasionally fail.