tests: fix TestExactAccountChunk#5993
Merged
gmalouf merged 2 commits intoalgorand:masterfrom May 9, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5993 +/- ##
==========================================
- Coverage 55.94% 55.93% -0.02%
==========================================
Files 482 482
Lines 68310 68310
==========================================
- Hits 38219 38212 -7
- Misses 27500 27502 +2
- Partials 2591 2596 +5 ☔ View full report in Codecov by Sentry. |
algorandskiy
force-pushed
the
pavel/ci-ledger-test-catchpoint
branch
from
97f19fd to
e3eb1f7
Compare
algorandskiy
force-pushed
the
pavel/ci-ledger-test-catchpoint
branch
from
748e168 to
3b92104
Compare
algorandskiy
changed the title
gmalouf
approved these changes
May 8, 2024
jasonpaulos
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestExactAccountChunkcompares MT stats on different components of aDoubleLeger. Sometimes these two might flush different number of rounds to disk causing different MTs (and catchpoint).Force flushing and waiting should after should minimize such discrepancy.
Testing
This is a fix to unstable
TestExactAccountChunkthat should pass.Run multiple times locally and on CI.