Skip to content

p2p: Telemetry and metrics improvements #6104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
algorandskiy wants to merge 2 commits into from
Closed

p2p: Telemetry and metrics improvements #6104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3eb13b0
p2p: Telemetry and metrics improvements
algorandskiy Aug 16, 2024
02b5eeb
Update network/p2p/pubsubTracer.go
algorandskiy Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/algod/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,8 @@ var startupConfigCheckFields = []string{
"TxPoolExponentialIncreaseFactor",
"TxPoolSize",
"VerifiedTranscationsCacheSize",
"EnableP2P",
"EnableP2PHybridMode",
Comment thread
algorandskiy marked this conversation as resolved.
}

func resolveDataDir() string {
Expand Down
13 changes: 12 additions & 1 deletion network/p2p/pubsubTracer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ var transactionMessagesP2PDuplicateMessage = metrics.MakeCounter(metrics.Transac
var transactionMessagesP2PDeliverMessage = metrics.MakeCounter(metrics.TransactionMessagesP2PDeliverMessage)
var transactionMessagesP2PUnderdeliverableMessage = metrics.MakeCounter(metrics.TransactionMessagesP2PUndeliverableMessage)
var transactionMessagesP2PValidateMessage = metrics.MakeCounter(metrics.TransactionMessagesP2PValidateMessage)
var transactionMessagesP2PSentMessages = metrics.MakeCounter(metrics.TransactionMessagesP2PSentMessage)
var transactionMessagesP2PSentBytes = metrics.MakeCounter(metrics.TransactionMessagesP2PSentBytes)

// pubsubTracer is a tracer for pubsub events used to track metrics.
type pubsubTracer struct{}
Expand Down Expand Up @@ -86,7 +88,16 @@ func (t pubsubTracer) ThrottlePeer(p peer.ID) {}
func (t pubsubTracer) RecvRPC(rpc *pubsub.RPC) {}

// SendRPC is invoked when a RPC is sent.
func (t pubsubTracer) SendRPC(rpc *pubsub.RPC, p peer.ID) {}
func (t pubsubTracer) SendRPC(rpc *pubsub.RPC, p peer.ID) {
if rpc != nil && len(rpc.Publish) > 0 {
for i := range rpc.Publish {
if rpc.Publish[i] != nil && rpc.Publish[i].Topic != nil && *rpc.Publish[i].Topic == TXTopicName {
transactionMessagesP2PSentMessages.Inc(nil)
transactionMessagesP2PSentBytes.AddUint64(uint64(len(rpc.Publish[i].Data)), nil)
}
}
}
}

// DropRPC is invoked when an outbound RPC is dropped, typically because of a queue full.
func (t pubsubTracer) DropRPC(rpc *pubsub.RPC, p peer.ID) {}
Expand Down
4 changes: 2 additions & 2 deletions test/heapwatch/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ plotly==5.16.0
py-algorand-sdk==2.3.0
kaleido==0.2.1
networkx==3.3
gravis=0.1.0
termcolor=2.4.0
gravis==0.1.0
termcolor==2.4.0
5 changes: 5 additions & 0 deletions util/metrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,11 @@ var (
// TransactionMessagesP2PValidateMessage "Number of p2p pubsub transaction messages received for validation"
TransactionMessagesP2PValidateMessage = MetricName{Name: "algod_transaction_messages_p2p_validate", Description: "Number of p2p pubsub transaction messages received for validation"}

// TransactionMessagesP2PSentMessage "Number of p2p pubsub transaction messages received for validation"
TransactionMessagesP2PSentMessage = MetricName{Name: "algod_transaction_messages_p2p_sent", Description: "Number of p2p pubsub transaction messages sent"}
// TransactionMessagesP2PSentBytes "Number p2p pubsub transaction bytes sent"
TransactionMessagesP2PSentBytes = MetricName{Name: "algod_transaction_messages_p2p_bytes", Description: "Number p2p pubsub transaction bytes sent"}

// TransactionGroupTxSyncHandled "Number of transaction groups handled via txsync"
TransactionGroupTxSyncHandled = MetricName{Name: "algod_transaction_group_txsync_handled", Description: "Number of transaction groups handled via txsync"}
// TransactionGroupTxSyncRemember "Number of transaction groups remembered via txsync"
Expand Down