p2p: Telemetry and metrics improvements#6104
Closed
algorandskiy wants to merge 2 commits intoalgorand:masterfrom
Closed
p2p: Telemetry and metrics improvements#6104algorandskiy wants to merge 2 commits intoalgorand:masterfrom
algorandskiy wants to merge 2 commits intoalgorand:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6104 +/- ##
==========================================
- Coverage 56.22% 56.21% -0.02%
==========================================
Files 490 490
Lines 69705 69710 +5
==========================================
- Hits 39191 39186 -5
- Misses 27840 27851 +11
+ Partials 2674 2673 -1 ☔ View full report in Codecov by Sentry. |
20c32ae to
1262954
Compare
1262954 to
3eb13b0
Compare
Contributor
Author
|
Fixed SendRPC checks |
gmalouf
previously approved these changes
Aug 19, 2024
cce
reviewed
Aug 20, 2024
cce
reviewed
Aug 20, 2024
Co-authored-by: cce <51567+cce@users.noreply.github.com>
cce
approved these changes
Aug 20, 2024
Contributor
Author
|
Closing, #6105 has all of it and much more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnableP2PandEnableP2PHybridModeto the telemetryStartupevent. This will allow to see fractions of WS, P2P and Hybrid nodes.pubsubTracer.SendRPCimplementation to track TX messages being broadcasted over the network. These will be the same asalgod_network_sent_bytes_TXandalgod_network_message_sent_TX.This is part 1 of a bigger change to separate metrics like
algod_network_sent_bytes_{TAG}for ws and p2p networks. The newly addedalgod_transaction_messages_p2p_sentwill be replaced byalgod_network_message_sent_TXbut this requires moving all of these into theutil/metricsto be used in bothnetworkpackage andnetwork/p2psub-packages. This would also allow to write a simple unit test for gossipsub metric (having the counter available in the node or network package).Test Plan
Tested locally with
goal network+pingpong+test/heapwatch/heapWatch.py --period 10 --metrics