network: remove ws net proto 2.1#6081
Merged
algorandskiy merged 5 commits intoalgorand:masterfrom Aug 8, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6081 +/- ##
==========================================
- Coverage 56.26% 56.23% -0.04%
==========================================
Files 488 488
Lines 69607 69561 -46
==========================================
- Hits 39166 39119 -47
+ Misses 27783 27782 -1
- Partials 2658 2660 +2 ☔ View full report in Codecov by Sentry. |
jasonpaulos
reviewed
Jul 26, 2024
1695ce7 to
3ce1bef
Compare
algorandskiy
commented
Jul 29, 2024
gmalouf
reviewed
Jul 29, 2024
gmalouf
reviewed
Jul 29, 2024
gmalouf
reviewed
Jul 29, 2024
gmalouf
reviewed
Jul 29, 2024
gmalouf
reviewed
Jul 29, 2024
Contributor
gmalouf
left a comment
There was a problem hiding this comment.
Looks good overall, asked a few questions.
gmalouf
previously approved these changes
Jul 29, 2024
jasonpaulos
previously approved these changes
Jul 30, 2024
algorandskiy
commented
Jul 30, 2024
jasonpaulos
previously approved these changes
Jul 31, 2024
gmalouf
previously approved these changes
Aug 2, 2024
cce
reviewed
Aug 8, 2024
jasonpaulos
approved these changes
Aug 8, 2024
gmalouf
approved these changes
Aug 8, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove wsnet proto=2.1 and optional compression since the entire network supports 2.2 and compressed PP messages.
I left couple commented out lines showing how to set and check features.
Test Plan
Existing tests