network: stateless vote compression#6276
Merged
cce merged 67 commits intoalgorand:masterfrom May 7, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6276 +/- ##
==========================================
+ Coverage 51.65% 51.84% +0.19%
==========================================
Files 649 652 +3
Lines 86964 87433 +469
==========================================
+ Hits 44918 45331 +413
- Misses 39192 39236 +44
- Partials 2854 2866 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jannotti
reviewed
Mar 14, 2025
Contributor
jannotti
left a comment
There was a problem hiding this comment.
Couple questions so far.
gmalouf
reviewed
Mar 18, 2025
gmalouf
reviewed
Mar 19, 2025
gmalouf
reviewed
Mar 19, 2025
gmalouf
reviewed
Mar 19, 2025
yossigi
reviewed
May 5, 2025
jannotti
previously approved these changes
May 6, 2025
gmalouf
previously approved these changes
May 6, 2025
algorandskiy
previously approved these changes
May 6, 2025
algorandskiy
approved these changes
May 6, 2025
jannotti
approved these changes
May 6, 2025
gmalouf
approved these changes
May 6, 2025
This was referenced May 15, 2025
cce
added a commit
to cce/go-algorand
that referenced
this pull request
May 29, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Similar to #4589 this provides single-message vote compression without any shared context between messages. It removes msgpack control characters and field names, reducing the size of votes down to just the values present, plus a 2-byte header. It provides 25% smaller messages on typical votes, compared to 6-7% smaller for zstd, and is >20x faster than zstd's fastest levels.
Test Plan
Adds features to algodump for benchmarking and testing against network data(will submit as separate PR)