Feature: Catchup Eval Stake Exception Round Handling#5795
Merged
gmalouf merged 7 commits intoalgorand:masterfrom Oct 23, 2023
Merged
Feature: Catchup Eval Stake Exception Round Handling#5795gmalouf merged 7 commits intoalgorand:masterfrom
gmalouf merged 7 commits intoalgorand:masterfrom
Conversation
This reverts commit cbde753.
gmalouf
requested review from
algorandskiy,
cce,
jannotti,
jasonpaulos and
ohill
jasonpaulos
reviewed
Oct 23, 2023
cce
reviewed
Oct 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #5795 +/- ##
==========================================
+ Coverage 55.56% 55.60% +0.03%
==========================================
Files 473 473
Lines 66813 66803 -10
==========================================
+ Hits 37124 37145 +21
+ Misses 27182 27152 -30
+ Partials 2507 2506 -1
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: cce <51567+cce@users.noreply.github.com>
cce
approved these changes
Oct 23, 2023
algorandskiy
approved these changes
Oct 23, 2023
jasonpaulos
approved these changes
Oct 23, 2023
algorandskiy
added a commit
to algorandskiy/go-algorand
that referenced
this pull request
Nov 14, 2023
This was referenced Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We had a brief period where a handful of rounds had stake miniscully mismatching in cases based on delta corruption in some nodes. This pull request ensures catchup cannot stall while removing the stake dilution factor (underlying cause/corrections were addressed in the last consensus upgrade).
Test Plan
Added a new
TestEval_EndOfBlockStake(thanks @algorandskiy ) to exercise various cases being handled as expected.