Enhancement: 1. go mod tidy + 2. diffutils when mac OS

[tzaffi]

Summary

Introducing make tidy and enforcing it in codegen_verification.sh as well as make sanity.

As go mod tidy's behavior can change from version to version of go, make tidy insists that the expected go build major version be applied.

(The build version is defined in scripts/get_golang_version.sh).

Also adding diffutils to configure_dev.sh mac install_or_upgrade()'s (see the comment below for an explanation)

Test Plan

CI and locally to ensure that make tidy works when the expected go-version hasn't already been installed.

[cce]

I think if you added your preferred invocation of go mod tidy (with whatever -compat flags we should use) to this shell script, it would complain at the end if there were dirty / uncommitted changes to go.mod and go.sum. We use this pattern for checking if you forgot to run make msgp, the swagger gen stuff, similar use case https://github.com/algorand/go-algorand/blob/master/scripts/travis/codegen_verification.sh

[cce]

You could also have this implemented with a few lines of circleci YAML or github actions YAML — I'm not sure that writing a custom Go program has any significant advantage over the shell and some CI glue e.g. https://github.com/katexochen/go-tidy-check/blob/main/action.yml

[codecov]

Codecov Report

Merging #5398 (7cbf8ca) into master (44f4da8) will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5398      +/-   ##
==========================================
+ Coverage   54.99%   55.34%   +0.34%     
==========================================
  Files         452      452              
  Lines       63851    63851              
==========================================
+ Hits        35117    35339     +222     
+ Misses      26314    26083     -231     
- Partials     2420     2429       +9     

see 28 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[winder]

It's nice that go install can manage this, but it still seems a little strange to me that this is done in the Makefile.

I'm not completely oppose to the change here, but exiting with an error that tells you the go version is wrong would be my preference. Maybe even split it out with a check target which checks your environment, and add that as a dependency to other things which might be wrongish with the wrong version of go installed.

[tzaffi]

c7e31fe

[gmalouf]

I'm mostly good with this, think you should add a call to tidy under the sanity make alias (I think just before the fix call).

[tzaffi]

I wasn't able to get make lint to pass locally until I installed diffutils per these links:

• lakeFS forum discussion
• Can't parse date when running  golangci/golangci-lint#3087

[tzaffi]

I'm mostly good with this, think you should add a call to tidy under the sanity make alias (I think just before the fix call).

See the latest