Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netdeploy: Copy ledger directory for kv tracker database #5392

Merged
merged 3 commits into from
May 18, 2023

Conversation

AlgoAxel
Copy link
Contributor

I mucked up my git space and need to reproduce my previous PR:

#5347

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #5392 (bdaa224) into master (cee1c81) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5392      +/-   ##
==========================================
+ Coverage   55.37%   55.39%   +0.01%     
==========================================
  Files         452      452              
  Lines       63685    63685              
==========================================
+ Hits        35268    35277       +9     
+ Misses      25991    25987       -4     
+ Partials     2426     2421       -5     

see 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

algorandskiy
algorandskiy previously approved these changes May 17, 2023
iansuvak
iansuvak previously approved these changes May 17, 2023
Copy link
Contributor

@iansuvak iansuvak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had the same question as Pavel on the previous PR re: mutual exclusivity but looks safe. LGTM

@AlgoAxel AlgoAxel dismissed stale reviews from iansuvak and algorandskiy via 2fc695e May 18, 2023 16:30
@algorandskiy algorandskiy changed the title Enhancement: Copy ledger directory for kv tracker database netdeploy: Copy ledger directory for kv tracker database May 18, 2023
@algorandskiy algorandskiy merged commit b376efd into algorand:master May 18, 2023
tzaffi pushed a commit to tzaffi/go-algorand that referenced this pull request May 22, 2023
wip

netdeploy: Copy ledger directory for kv tracker database (algorand#5392)

assembler: Error if extra args are present in pragmas (algorand#5400)

ledger: Exclude stake at R-320 that is expired by R (algorand#5403)

Co-authored-by: cce <[email protected]>

algod: Don't return a top level array from algod (algorand#5404)

revert

go get github.com/algorand/[email protected]

go get github.com/getkin/[email protected]

go mod tidy -compat=1.17

go get github.com/algorand/[email protected]

go mod tidy -compat=1.17

go get github.com/algorand/[email protected]

revert to master

github.com/getkin/kin-openapi v0.117.0

github.com/getkin/kin-openapi v0.117.0

github.com/getkin/kin-openapi v0.117.0

go get golang.org/x/mod/modfile

tidy #0

go get github.com/algorand/[email protected]

go mod tidy

tidy up after every go get

simplify

revert

tidier

tg

tg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants