tools: Remove vbconvert#5133
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5133 +/- ##
=======================================
Coverage 53.42% 53.42%
=======================================
Files 431 431
Lines 54364 54364
=======================================
+ Hits 29044 29045 +1
+ Misses 23064 23059 -5
- Partials 2256 2260 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
winder
approved these changes
Feb 11, 2023
jasonpaulos
approved these changes
Feb 13, 2023
Contributor
jasonpaulos
left a comment
jasonpaulos
left a comment
There was a problem hiding this comment.
I agree with #5123 (comment), this looks good to remove
algorandskiy
approved these changes
Feb 13, 2023
This was referenced Mar 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
vbconverttool. We no longer need it since we're not redefiningStateDeltatypes in the deltas endpoint.